Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final ABI renames #5252

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Final ABI renames #5252

merged 1 commit into from
Jul 17, 2024

Conversation

robertbastian
Copy link
Member

@robertbastian robertbastian commented Jul 17, 2024 •
edited
Loading

Part of #3790

@robertbastian robertbastian marked this pull request as ready for review July 17, 2024 17:31
@robertbastian robertbastian requested review from Manishearth and a team as code owners July 17, 2024 17:31
Manishearth
Manishearth approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@Manishearth Manishearth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github UI is being slow but for others who wish to take a look: all this does is apply the icu4x_{}_mv1 abi rename (yay!)

the type renames from ICU4XFoo already happened

@Manishearth Manishearth merged commit e40ba18 into unicode-org:main Jul 17, 2024
28 checks passed
@Manishearth
Copy link
Member

merging myself since it's a large PR that will conflict with everyone else

@robertbastian robertbastian deleted the abi branch July 18, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertbastian @Manishearth