Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep icu_datetime compatible and bump crate versions to 0.1.1 #531

Closed
wants to merge 3 commits into from
Closed

Keep icu_datetime compatible and bump crate versions to 0.1.1 #531

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 4, 2021

icu_datetime changed the location of MockDateTime structure, so I put it back on the icu_datetime::date module. Also, if possible, would like if you could publish it (and icu_testdata) to crates.io.

@ghost ghost requested review from sffc and zbraniecki as code owners March 4, 2021 18:10
@coveralls
Copy link

Pull Request Test Coverage Report for Build b5dd59e801f5741e1311b4b6316345ffd214103a-PR-531

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 72.707%

Files with Coverage Reduction New Missed Lines %
components/datetime/src/date.rs 1 28.75%
Totals Coverage Status
Change from base Build 9b0fa09152aea4de2f8a37628d0bebb9ebb50f3d: 0.0%
Covered Lines: 4851
Relevant Lines: 6672

💛 - Coveralls

Base automatically changed from master to main March 4, 2021 18:40
@sffc
Copy link
Member

sffc commented Mar 4, 2021

I'm not opposed to releasing 0.1.1 of icu_testdata to fix the bug from #527, but I don't want to release 0.2 of icu_datetime until we're ready with all the pending feature work. There are several open PRs to commit further changes to icu_datetime.

Note: 0.1 is a very early alpha release of ICU4X, and we aren't yet giving any guarantees about it being stable or production-ready.

@ghost
Copy link
Author

ghost commented Mar 5, 2021

I bumped icu_datetime version to 0.1.1 this time. In a previous PR I bumped it to 0.2 because it was not backwards-compatible with MockDateTime.

@ghost ghost closed this Mar 6, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants