Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attribute filtering during export #5320

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Attribute filtering during export #5320

merged 3 commits into from
Aug 6, 2024

Conversation

robertbastian
Copy link
Member

@robertbastian robertbastian commented Jul 31, 2024 •
edited
Loading

@robertbastian robertbastian marked this pull request as ready for review July 31, 2024 15:32
sffc
sffc previously approved these changes Aug 6, 2024
View reviewed changes
provider/export/src/lib.rs Outdated Show resolved Hide resolved
@robertbastian robertbastian requested a review from sffc August 6, 2024 15:28
@sffc
Copy link
Member

sffc commented Aug 6, 2024

Strawperson for the CLI: --attribute-allowlist collation foo bar --attribute-denylist units meter foot

@robertbastian robertbastian merged commit 35ef707 into unicode-org:main Aug 6, 2024
28 checks passed
@robertbastian robertbastian deleted the attrs branch August 6, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younies younies younies left review comments

@sffc sffc sffc approved these changes

@Manishearth Manishearth Awaiting requested review from Manishearth Manishearth is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertbastian @sffc @younies