Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring time zone length behavior up to spec #5563

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sffc
Copy link
Member

@sffc sffc commented Sep 19, 2024

Time zone length works like all other fields, except that it always prefers short when used in a pattern with other fields.

It does create an edge case where the constructor can return TypeTooNarrow, which is shown via a docs test.

@sffc sffc requested review from Manishearth and removed request for zbraniecki and nordzilla September 19, 2024 23:17
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cumulative praise: I really appreciate how the neo design is much more uniform and easy to look at, the time zone code used to be much messier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants