-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump MSRV to 1.80 #5934
base: main
Are you sure you want to change the base?
Bump MSRV to 1.80 #5934
Conversation
n.b. I kept the rustdoc nightly and the LLVM nightly separate to keep an indicator that they can be separate. However I could homogenize them if desired. |
59e173f
to
19a5c87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait on #5935 first. Sorry.
There's a lot of good stuff in here. I think we can get to Rust 1.75 at least, and maybe Rust 1.76, without bumping LLVM. It sadly doesn't get us That said, if there isn't anything in 1.76 that we care about, then we should lean toward lower MSRV when possible. |
Also, for the specific problem of if i <= my_slice.len() {
Some(my_slice.split_at(i))
} else {
None
} In other words, the bounds check inside So, although I would be very happy to use |
Yeah I proposed this before, I don't recall what Henri felt about that. I'll comment on the other issue. |
I actually feel that the reason of "we should start 2.0 with a relatively upgraded rustc so that future upgrades are rarer" is a more compelling reason than this one API. I consider the ability to run a pair of niche FFI tests on a default Mac install to be negligible in value. |
I agree with this and am okay temporarily relaxing the Xcode constraint in order to reduce the number of MSRV changes in the 2.x stream.
Discussed in #5945; it's about how a prototypical ICU4X iOS developer, one who is expected to care about binary size, should use ICU4X, not just "running niche FFI tests on a default Mac install." |
Changed in the PR. |
No description provided.