Add with_fset fns to datetime types #5942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
previously approved these changes
Dec 20, 2024
|
|
||
| /// A trait for a [`DateTimeNamesMarker`] that can be created from a more specific one, `M`. | ||
| /// | ||
| /// This trait is blanket-implemented on all field sets that are more general than `M`. |
There was a problem hiding this comment.
nit: link to the fieldset module
| @@ -93,8 +95,30 @@ icu::datetime::Length::into_option#FnInEnum | |||
| icu::datetime::MismatchedCalendarError#Struct | |||
| icu::datetime::TimeFormatter#Typedef | |||
| icu::datetime::fieldsets::Combo#Struct | |||
| icu::datetime::fieldsets::Combo::map_day_period_names#FnInStruct | |||
There was a problem hiding this comment.
nit: add DateTimeNamesFrom to the allowlisted traits
Manishearth
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5940