Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZeroMap #668

Merged
merged 20 commits into from
Apr 23, 2021
Merged

Add ZeroMap #668

merged 20 commits into from
Apr 23, 2021

Conversation

Manishearth
Copy link
Member

@Manishearth Manishearth commented Apr 21, 2021

TBD:

  • Benches
  • Nicer .get() for ULE types

Part of #652

@Manishearth Manishearth requested a review from a team as a code owner April 21, 2021 03:08
@Manishearth Manishearth requested a review from sffc April 21, 2021 03:08
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • utils/zerovec/src/zerovec/mod.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2021

Codecov Report

Merging #668 (650e8fb) into main (7d78c20) will increase coverage by 0.11%.
The diff coverage is 81.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #668      +/-   ##
==========================================
+ Coverage   74.13%   74.24%   +0.11%     
==========================================
  Files         167      171       +4     
  Lines       10627    10824     +197     
==========================================
+ Hits         7878     8036     +158     
- Misses       2749     2788      +39     
Impacted Files Coverage Δ
utils/zerovec/src/lib.rs 100.00% <ø> (ø)
utils/zerovec/src/zerovec/mod.rs 67.00% <54.54%> (-1.54%) ⬇️
utils/zerovec/src/map/kv.rs 64.70% <64.70%> (ø)
utils/zerovec/src/map/serde.rs 81.96% <81.96%> (ø)
utils/zerovec/src/map/vecs.rs 85.10% <85.10%> (ø)
utils/zerovec/src/map/mod.rs 92.50% <92.50%> (ø)
utils/zerovec/src/varzerovec/mod.rs 60.60% <100.00%> (+1.58%) ⬆️
utils/zerovec/src/varzerovec/components.rs 81.48% <0.00%> (-2.57%) ⬇️
utils/zerovec/src/ule/plain.rs 0.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d78c20...650e8fb. Read the comment docs.

@coveralls
Copy link

coveralls commented Apr 21, 2021

Pull Request Test Coverage Report for Build b01b7be3b1f350f5f2ca3f55ac2cedbdd5c9a411-PR-668

  • 145 of 177 (81.92%) changed or added relevant lines in 6 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.1%) to 73.492%

Changes Missing Coverage Covered Lines Changed/Added Lines %
utils/zerovec/src/map/mod.rs 37 40 92.5%
utils/zerovec/src/zerovec/mod.rs 6 11 54.55%
utils/zerovec/src/map/kv.rs 11 17 64.71%
utils/zerovec/src/map/vecs.rs 40 47 85.11%
utils/zerovec/src/map/serde.rs 50 61 81.97%
Files with Coverage Reduction New Missed Lines %
utils/zerovec/src/varzerovec/mod.rs 1 60.61%
utils/zerovec/src/ule/plain.rs 2 0%
utils/zerovec/src/varzerovec/components.rs 5 81.48%
Totals Coverage Status
Change from base Build 6daf09323a50001967fcabd778d96aa9176f3cc5: 0.1%
Covered Lines: 8162
Relevant Lines: 11106

💛 - Coveralls

utils/zerovec/src/map/kv.rs Outdated Show resolved Hide resolved
utils/zerovec/src/map/vecs.rs Show resolved Hide resolved
utils/zerovec/src/map/kv.rs Outdated Show resolved Hide resolved
utils/zerovec/src/map/serde.rs Outdated Show resolved Hide resolved
@Manishearth Manishearth requested a review from sffc April 22, 2021 21:56
utils/zerovec/src/map/vecs.rs Show resolved Hide resolved
utils/zerovec/src/map/vecs.rs Show resolved Hide resolved
utils/zerovec/src/map/vecs.rs Show resolved Hide resolved
utils/zerovec/src/map/serde.rs Outdated Show resolved Hide resolved
utils/zerovec/src/map/kv.rs Outdated Show resolved Hide resolved
utils/zerovec/src/map/serde.rs Outdated Show resolved Hide resolved
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • utils/zerovec/src/varzerovec/mod.rs is different
  • utils/zerovec/src/zerovec/mod.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • utils/zerovec/src/map/vecs.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

utils/zerovec/src/map/mod.rs Outdated Show resolved Hide resolved
utils/zerovec/src/map/mod.rs Outdated Show resolved Hide resolved
utils/zerovec/src/map/mod.rs Outdated Show resolved Hide resolved
@Manishearth Manishearth requested a review from sffc April 23, 2021 00:00
sffc
sffc previously approved these changes Apr 23, 2021
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But please fix the lint error

@Manishearth Manishearth requested a review from sffc April 23, 2021 14:22
@Manishearth Manishearth added the waiting-on-reviewer PRs waiting for action from the reviewer for >7 days label Apr 23, 2021
@Manishearth Manishearth merged commit 74eb46d into unicode-org:main Apr 23, 2021
@Manishearth Manishearth deleted the zeromap branch April 23, 2021 17:52
@sffc sffc linked an issue Apr 28, 2021 that may be closed by this pull request
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on-reviewer PRs waiting for action from the reviewer for >7 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement and optimize ZeroVec
5 participants