(old PR) WIP: Add yoke crate #696

Manishearth · 2021-05-01T00:33:23Z

Superseded by #705

jira-pull-request-webhook · 2021-05-01T00:42:34Z

Notice: the branch changed across the force-push!

utils/yoke/src/yokeable.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2021-05-01T00:46:40Z

Notice: the branch changed across the force-push!

utils/yoke/src/cart.rs is different
utils/yoke/src/yokeable.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2021-05-01T01:18:45Z

Notice: the branch changed across the force-push!

utils/yoke/src/yoke.rs is different
utils/yoke/src/yokeable.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2021-05-01T01:20:24Z

Notice: the branch changed across the force-push!

utils/yoke/src/yokeable.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

sffc

Nifty!

sffc · 2021-05-01T01:26:56Z

utils/yoke/src/yokeable.rs

+    }
+
+    unsafe fn make(from: Cow<'a, T>) -> Self {
+        debug_assert!(mem::size_of::<Cow<'a, T>>() == mem::size_of::<Self>());


static_assert instead?

rust doesn't have that; because Rust generics are not typechecked at substitution (unlike templates)

So, in other words, this is impossible to test at build time, even if you were to use https://docs.rs/static_assertions/1.1.0/static_assertions/ ?

Yes, and the static assertions crate uses tricks like mem::transmute which doesn't work here.

It might be possible to test using consts. I'm not sure, but it would be super happy

utils/yoke/src/yokeable.rs

sffc · 2021-05-01T01:29:54Z

utils/yoke/src/yokeable.rs

+    cow: Cow<'static, str>,
+}
+
+// The following code should NOT compile!!!


https://users.rust-lang.org/t/testing-that-code-does-not-compile/33521/7 ?

maybe! I'm not a huge fan of pulling in additional tooling for this

Rustdoc has compile_fail, used it

jira-pull-request-webhook · 2021-05-01T04:25:05Z

Notice: the branch changed across the force-push!

utils/yoke/src/yoke.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2021-05-01T13:58:39Z

Notice: the branch changed across the force-push!

utils/yoke/src/cart.rs is no longer changed in the branch
utils/yoke/src/lib.rs is different
utils/yoke/src/yoke.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2021-05-02T02:37:35Z

Notice: the branch changed across the force-push!

Cargo.lock is different
utils/yoke/Cargo.toml is different
utils/yoke/src/lib.rs is different
utils/yoke/src/yoke.rs is different
utils/yoke/src/yokeable.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2021-05-03T23:04:04Z

Notice: the branch changed across the force-push!

utils/yoke/src/lib.rs is different
utils/yoke/src/yoke.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2021-05-04T19:09:30Z

Notice: the branch changed across the force-push!

utils/yoke/src/cart.rs is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2021-05-04T23:51:49Z

Notice: the branch changed across the force-push!

utils/yoke/src/lib.rs is different
utils/yoke/src/yoke.rs is different
utils/yoke/src/yokeable.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

codecov-commenter · 2021-05-05T00:04:49Z

Codecov Report

Merging #696 (b34fada) into main (478c4a9) will decrease coverage by 0.44%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main     #696      +/-   ##
==========================================
- Coverage   74.18%   73.74%   -0.45%     
==========================================
  Files         171      177       +6     
  Lines       10802    10869      +67     
==========================================
+ Hits         8014     8015       +1     
- Misses       2788     2854      +66

Impacted Files	Coverage Δ
utils/yoke/src/cart.rs	`0.00% <0.00%> (ø)`
utils/yoke/src/lib.rs	`100.00% <100.00%> (ø)`
components/capi/src/pluralrules.rs	`0.00% <0.00%> (ø)`
components/capi/src/fixed_decimal.rs	`0.00% <0.00%> (ø)`
components/capi/src/macros.rs	`0.00% <0.00%> (ø)`
components/capi/src/decimal.rs	`0.00% <0.00%> (ø)`
components/capi/src/custom_writeable.rs	`0.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 478c4a9...b34fada. Read the comment docs.

coveralls · 2021-05-05T00:06:00Z

Pull Request Test Coverage Report for Build 6208b9c6cbf3234e62de2b3be7fc7d708bd4b61b-PR-696

1 of 4 (25.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 74.097%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
utils/yoke/src/cart.rs	0	3	0.0%

Totals
Change from base Build c6582ccddf87d49a44e2d4e54604543365c76bff:	-0.02%
Covered Lines:	8127
Relevant Lines:	10968

💛 - Coveralls

jira-pull-request-webhook · 2021-05-05T00:08:37Z

Notice: the branch changed across the force-push!

utils/yoke/src/cart.rs is different
utils/yoke/src/yokeable.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2021-05-05T01:18:47Z

Notice: the branch changed across the force-push!

Cargo.lock is different
utils/yoke/Cargo.toml is different
utils/yoke/src/cart.rs is different
utils/yoke/src/yoke.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2021-05-05T01:36:45Z

Notice: the branch changed across the force-push!

utils/yoke/src/yoke.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2021-05-05T01:44:16Z

Notice: the branch changed across the force-push!

utils/yoke/src/yoke.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Manishearth · 2021-05-05T01:55:07Z

Current status: hitting rust-lang/rust#84937 with using attach_to_cart(), temporarily worked around it by introducing attach_to_cart_but_worse() so that I can write tests and examples that work.

jira-pull-request-webhook · 2021-05-05T06:33:55Z

Notice: the branch changed across the force-push!

utils/yoke/src/yoke.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2021-05-05T18:12:16Z

Notice: the branch changed across the force-push!

utils/yoke/Cargo.toml is different
utils/yoke/src/cart.rs is different
utils/yoke/src/lib.rs is different
utils/yoke/src/yoke.rs is different
utils/yoke/src/yokeable.rs is different
utils/yoke/src/zerovec_impls.rs is now changed in the branch
utils/yoke/tests/bincode.rs is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Manishearth · 2021-05-05T18:13:03Z

Closing because the jira bot has left too many comments, going to open a new PR for review

Manishearth · 2021-05-05T18:37:25Z

#705

Manishearth force-pushed the yoke branch from 9724f0d to adb44bf Compare May 1, 2021 00:42

Manishearth force-pushed the yoke branch from adb44bf to 9a9c30d Compare May 1, 2021 00:46

Manishearth force-pushed the yoke branch from 9a9c30d to 2f12a0c Compare May 1, 2021 01:18

Manishearth force-pushed the yoke branch from 2f12a0c to d9a19a0 Compare May 1, 2021 01:20

sffc reviewed May 1, 2021

View reviewed changes

Manishearth force-pushed the yoke branch from d9a19a0 to 87a3546 Compare May 1, 2021 04:25

Manishearth force-pushed the yoke branch from 87a3546 to 3176f4d Compare May 1, 2021 13:58

Manishearth force-pushed the yoke branch from 3176f4d to a9151dd Compare May 2, 2021 02:37

Manishearth force-pushed the yoke branch from a9151dd to 361d975 Compare May 3, 2021 23:04

Manishearth force-pushed the yoke branch from 361d975 to e33b760 Compare May 4, 2021 19:09

Manishearth force-pushed the yoke branch from e33b760 to b34fada Compare May 4, 2021 23:51

Manishearth force-pushed the yoke branch from b34fada to f4b382a Compare May 5, 2021 00:08

Manishearth force-pushed the yoke branch from f4b382a to 922326a Compare May 5, 2021 01:18

Manishearth force-pushed the yoke branch from 922326a to 1f8e5b3 Compare May 5, 2021 01:36

Manishearth force-pushed the yoke branch from 1f8e5b3 to 93510a4 Compare May 5, 2021 01:44

Manishearth force-pushed the yoke branch from 93510a4 to 8e72a49 Compare May 5, 2021 06:33

Add yoke crate

24d41e5

Manishearth force-pushed the yoke branch from 8e72a49 to 24d41e5 Compare May 5, 2021 18:12

Manishearth closed this May 5, 2021

Manishearth mentioned this pull request May 5, 2021

Add yoke crate #705

Merged

Manishearth changed the title ~~WIP: Add yoke crate~~ (old PR) WIP: Add yoke crate May 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(old PR) WIP: Add yoke crate #696

(old PR) WIP: Add yoke crate #696

Manishearth commented May 1, 2021 •

edited

Loading

jira-pull-request-webhook bot commented May 1, 2021

jira-pull-request-webhook bot commented May 1, 2021

jira-pull-request-webhook bot commented May 1, 2021

jira-pull-request-webhook bot commented May 1, 2021

sffc left a comment

sffc May 1, 2021

Manishearth May 1, 2021

sffc May 1, 2021

Manishearth May 2, 2021

sffc May 1, 2021

Manishearth May 1, 2021

Manishearth May 5, 2021

jira-pull-request-webhook bot commented May 1, 2021

jira-pull-request-webhook bot commented May 1, 2021

jira-pull-request-webhook bot commented May 2, 2021

jira-pull-request-webhook bot commented May 3, 2021

jira-pull-request-webhook bot commented May 4, 2021

jira-pull-request-webhook bot commented May 4, 2021

codecov-commenter commented May 5, 2021

coveralls commented May 5, 2021 •

edited

Loading

jira-pull-request-webhook bot commented May 5, 2021

jira-pull-request-webhook bot commented May 5, 2021

jira-pull-request-webhook bot commented May 5, 2021

jira-pull-request-webhook bot commented May 5, 2021

Manishearth commented May 5, 2021

jira-pull-request-webhook bot commented May 5, 2021

jira-pull-request-webhook bot commented May 5, 2021

Manishearth commented May 5, 2021

Manishearth commented May 5, 2021

(old PR) WIP: Add yoke crate #696

(old PR) WIP: Add yoke crate #696

Conversation

Manishearth commented May 1, 2021 • edited Loading

jira-pull-request-webhook bot commented May 1, 2021

jira-pull-request-webhook bot commented May 1, 2021

jira-pull-request-webhook bot commented May 1, 2021

jira-pull-request-webhook bot commented May 1, 2021

sffc left a comment

Choose a reason for hiding this comment

sffc May 1, 2021

Choose a reason for hiding this comment

Manishearth May 1, 2021

Choose a reason for hiding this comment

sffc May 1, 2021

Choose a reason for hiding this comment

Manishearth May 2, 2021

Choose a reason for hiding this comment

sffc May 1, 2021

Choose a reason for hiding this comment

Manishearth May 1, 2021

Choose a reason for hiding this comment

Manishearth May 5, 2021

Choose a reason for hiding this comment

jira-pull-request-webhook bot commented May 1, 2021

jira-pull-request-webhook bot commented May 1, 2021

jira-pull-request-webhook bot commented May 2, 2021

jira-pull-request-webhook bot commented May 3, 2021

jira-pull-request-webhook bot commented May 4, 2021

jira-pull-request-webhook bot commented May 4, 2021

codecov-commenter commented May 5, 2021

Codecov Report

coveralls commented May 5, 2021 • edited Loading

Pull Request Test Coverage Report for Build 6208b9c6cbf3234e62de2b3be7fc7d708bd4b61b-PR-696

💛 - Coveralls

jira-pull-request-webhook bot commented May 5, 2021

jira-pull-request-webhook bot commented May 5, 2021

jira-pull-request-webhook bot commented May 5, 2021

jira-pull-request-webhook bot commented May 5, 2021

Manishearth commented May 5, 2021

jira-pull-request-webhook bot commented May 5, 2021

jira-pull-request-webhook bot commented May 5, 2021

Manishearth commented May 5, 2021

Manishearth commented May 5, 2021

Manishearth commented May 1, 2021 •

edited

Loading

coveralls commented May 5, 2021 •

edited

Loading