Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cargo quick #826

Merged
merged 2 commits into from
Jun 25, 2021
Merged

Fix cargo quick #826

merged 2 commits into from
Jun 25, 2021

Conversation

sffc
Copy link
Member

@sffc sffc commented Jun 24, 2021

No description provided.

description = "Run clippy (this target is used locally, not on CI)"
category = "ICU4X Development"
command = "cargo"
args = ["clippy", "--all-targets", "--all-features", "--", "-D", "warnings", "-Aclippy::unknown-clippy-lints", "-Aclippy::field-reassign-with-default"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should just be args = ["clippy-all"]

@sffc
Copy link
Member Author

sffc commented Jun 24, 2021

Comment from @Manishearth on #820:

issue: there should be a comment here saying that this list must be kept in sync with the github action, and a comment there pointing here. Actually, no, we already have cargo clippy-all, this should just call cargo clippy-all

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2021

Codecov Report

Merging #826 (5a0a705) into main (2b7ca3b) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #826      +/-   ##
==========================================
+ Coverage   75.34%   75.45%   +0.11%     
==========================================
  Files         197      193       -4     
  Lines       12563    12489      -74     
==========================================
- Hits         9466     9424      -42     
+ Misses       3097     3065      -32     
Impacted Files Coverage Δ
components/decimal/src/provider.rs 62.50% <0.00%> (-9.38%) ⬇️
experimental/provider_static/src/lib.rs 3.84% <0.00%> (-0.16%) ⬇️
provider/cldr/src/transform/numbers/cldr_serde.rs 64.91% <0.00%> (ø)
provider/testdata/src/lib.rs
provider/testdata/src/metadata.rs
provider/testdata/src/test_data_provider.rs
provider/testdata/src/paths.rs
components/decimal/src/format.rs 86.20% <0.00%> (+2.33%) ⬆️
...ider/cldr/src/transform/numbers/decimal_pattern.rs 83.17% <0.00%> (+5.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b7ca3b...5a0a705. Read the comment docs.

@coveralls
Copy link

coveralls commented Jun 24, 2021

Pull Request Test Coverage Report for Build 4e6110f358da564bef85cad4fa373508ae6be1e4-PR-826

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 39 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.02%) to 75.528%

Files with Coverage Reduction New Missed Lines %
experimental/provider_static/src/lib.rs 6 3.85%
provider/cldr/src/transform/numbers/decimal_pattern.rs 9 83.18%
components/decimal/src/provider.rs 10 62.5%
provider/cldr/src/transform/numbers/cldr_serde.rs 14 64.91%
Totals Coverage Status
Change from base Build 2b7ca3bd55486daafbcf579d05243773e006ec89: 0.02%
Covered Lines: 9552
Relevant Lines: 12647

💛 - Coveralls

@sffc sffc marked this pull request as ready for review June 25, 2021 02:27
@sffc sffc requested a review from a team as a code owner June 25, 2021 02:27
@sffc sffc merged commit 6b79658 into unicode-org:main Jun 25, 2021
@sffc sffc deleted the cargo-quick branch June 25, 2021 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants