-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DataPayload::from_borrowed #898
Conversation
where | ||
T: ZonedDateTimeInput, | ||
{ | ||
pub(crate) zoned_datetime_format: &'l ZonedDateTimeFormat<'l>, | ||
pub(crate) zoned_datetime_format: &'l ZonedDateTimeFormat<'d>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nordzilla I had to add a second lifetime parameter to FormattedZonedDateTime
because the lifetime on the ZonedDateTimeFormat
can be different than the lifetime of the borrow. I ran into this when refactoring the DateTime test.
Codecov Report
@@ Coverage Diff @@
## main #898 +/- ##
==========================================
+ Coverage 74.31% 74.34% +0.02%
==========================================
Files 210 206 -4
Lines 12475 12352 -123
==========================================
- Hits 9271 9183 -88
+ Misses 3204 3169 -35
Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build eb8f822e9972edf8a3325c76cd10ecb87a4b6c6f-PR-898
💛 - Coveralls |
Step toward #752
This PR removes the public function DataPayload::from_borrowed. It does not actually remove the variant, because doing so will require performing the large refactor that removes the second lifetime argument; I would rather do that in its own PR (coming next after this one).