Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DataPayload::from_borrowed #898

Merged
merged 8 commits into from
Jul 26, 2021
Merged

Remove DataPayload::from_borrowed #898

merged 8 commits into from
Jul 26, 2021

Conversation

sffc
Copy link
Member

@sffc sffc commented Jul 24, 2021

Step toward #752

This PR removes the public function DataPayload::from_borrowed. It does not actually remove the variant, because doing so will require performing the large refactor that removes the second lifetime argument; I would rather do that in its own PR (coming next after this one).

@sffc sffc requested a review from Manishearth July 24, 2021 23:17
@sffc sffc requested review from zbraniecki and a team as code owners July 24, 2021 23:17
@sffc sffc removed request for a team and zbraniecki July 24, 2021 23:17
where
T: ZonedDateTimeInput,
{
pub(crate) zoned_datetime_format: &'l ZonedDateTimeFormat<'l>,
pub(crate) zoned_datetime_format: &'l ZonedDateTimeFormat<'d>,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nordzilla I had to add a second lifetime parameter to FormattedZonedDateTime because the lifetime on the ZonedDateTimeFormat can be different than the lifetime of the borrow. I ran into this when refactoring the DateTime test.

@codecov-commenter
Copy link

Codecov Report

Merging #898 (ef4e9db) into main (f5bc166) will increase coverage by 0.02%.
The diff coverage is 86.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #898      +/-   ##
==========================================
+ Coverage   74.31%   74.34%   +0.02%     
==========================================
  Files         210      206       -4     
  Lines       12475    12352     -123     
==========================================
- Hits         9271     9183      -88     
+ Misses       3204     3169      -35     
Impacted Files Coverage Δ
provider/core/src/erased.rs 76.28% <50.00%> (-6.60%) ⬇️
provider/core/src/data_provider/test.rs 91.95% <87.50%> (+0.08%) ⬆️
components/decimal/src/grouper.rs 93.10% <100.00%> (+0.12%) ⬆️
provider/core/src/data_provider.rs 83.11% <100.00%> (+5.61%) ⬆️
provider/core/src/marker/impls.rs 100.00% <100.00%> (ø)
provider/core/src/struct_provider.rs 85.71% <100.00%> (ø)
components/datetime/src/provider/gregory.rs 63.01% <0.00%> (-12.33%) ⬇️
utils/yoke/src/zero_copy_from.rs 75.00% <0.00%> (-2.78%) ⬇️
provider/core/src/dynutil.rs 37.14% <0.00%> (-1.75%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5bc166...ef4e9db. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build eb8f822e9972edf8a3325c76cd10ecb87a4b6c6f-PR-898

  • 38 of 44 (86.36%) changed or added relevant lines in 6 files are covered.
  • 19 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.07%) to 74.411%

Changes Missing Coverage Covered Lines Changed/Added Lines %
provider/core/src/erased.rs 2 4 50.0%
provider/core/src/data_provider/test.rs 28 32 87.5%
Files with Coverage Reduction New Missed Lines %
experimental/provider_ppucd/src/parse_ppucd.rs 1 93.29%
provider/core/src/data_provider/test.rs 3 91.95%
provider/core/src/erased.rs 6 76.29%
components/datetime/src/provider/gregory.rs 9 63.01%
Totals Coverage Status
Change from base Build f5bc1660a2efa1c88f6ab3ee7a6e68af92498ffd: -0.07%
Covered Lines: 9314
Relevant Lines: 12517

💛 - Coveralls

@sffc sffc merged commit 7ed372f into unicode-org:main Jul 26, 2021
@sffc sffc deleted the del_borrowed branch July 26, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants