Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add human-readable meta-data (title, description, examples) to registry entries #405

Closed
stasm opened this issue Jul 3, 2023 · 6 comments
Labels
registry Issue pertains to the function registry

Comments

@stasm
Copy link
Collaborator

stasm commented Jul 3, 2023

A follow-up to #368.

The current draft of the registry spec omits all human-readable descriptions. @aphillips noted in #368 (comment):

I assume this title (and others such as the one on line 24) are meant to be human readable descriptions of the function/input/parameter? If so, it's bad practice to make them an attribute--because they can't easily be localized that way. It's better to make subsidiary elements to contain natural language text. The title fields don't appear to be necessary to the functionality in any case.

@aphillips aphillips added the registry Issue pertains to the function registry label Jul 29, 2023
@aphillips
Copy link
Member

I think a registry without human-readable (natural language) metadata will have a lot of unstructured comments in it.

I support adding fields like title or description to assist in making the registry (and specific implementations of the registry) usable. However, if we add these fields, we should definitely do so in an internationalized way--allowing multiple descriptions in different languages and with language tags (even if the default registry comes with lang="und" or lang="en" only)

@macchiati
Copy link
Member

macchiati commented Jul 29, 2023 via email

@mihnita
Copy link
Collaborator

mihnita commented Jul 31, 2023

+1 to separate files


I would also add URLs. Quite useful, and if we don't have something dedicated then people will dump them in <description>

@aphillips
Copy link
Member

I didn't specify the exact mechanism, but we should hew to best practices in this space. True documentation should live in documentation space. Machine readable documentation should not overlook what's needed. That is, if we have:

<function>
   <description>This does something useful...</description>

We should do:

<function>
   <description xml:lang="en">This does something useful...</description>

I support providing URLs.

@aphillips
Copy link
Member

@eemeli per our slack conversation Monday, see the preceding comments...

@eemeli
Copy link
Collaborator

eemeli commented Dec 12, 2023

Resolved in #533.

@eemeli eemeli closed this as completed Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
registry Issue pertains to the function registry
Projects
None yet
Development

No branches or pull requests

5 participants