Update ts_data_models_name_mapping.md #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding coalesced Eemeli+Zibi naming scheme
zbraniecki
requested review from
echeran,
mihnita,
nbouvrette,
romulocintra and
stasm
as code owners
echeran
approved these changes
Feb 15, 2021
There was a problem hiding this comment.
LGTM, r+, etc.
Although FYI, you're now mixing types in a table that currently only has entity names (not even field names, at least not yet). We don't want to get too far into the weeds in Thursday's meeting on that so as to save for the monthly plenary mtg, as we said in today's meeting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding coalesced Eemeli+Zibi naming scheme