Fix Extended_Pictographic in UnicodeProperty for JSP #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macchiati
approved these changes
Jul 20, 2021
|
CLDR has the same code (but outdated). I don't think it matters there,
since we want to end up removing UnicodeProperty from CLDR.
Mark
…On Tue, Jul 20, 2021 at 2:22 PM Steven R. Loomis ***@***.***> wrote:
For #97 <#97>
This is the only property-specific site that calls setUniformUnassigned
that I could find so far, and it's in the JSPs. Should there be a site
within the main tools that has NONCHARACTER_CODE_POINT etc?
I'll get this posted somewhere and then work on adding a test.
------------------------------
You can view, comment on, or merge this pull request online at:
#105
Commit Summary
- Fix Extended_Pictographic in UnicodeProperty for JSP
File Changes
- *M* UnicodeJsps/src/main/java/org/unicode/jsp/ICUPropertyFactory.java
<https://github.com/unicode-org/unicodetools/pull/105/files#diff-6aafe43558cb4f0cc881969f9136cac56d63d47e3d2cc5dc90cd159428c8a016>
(33)
Patch Links:
- https://github.com/unicode-org/unicodetools/pull/105.patch
- https://github.com/unicode-org/unicodetools/pull/105.diff
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#105>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMD3IKLDSLI43HKQ4M3TYXSK7ANCNFSM5AWUEYTQ>
.
|
|
Great! Could you please let me know when it is in a testing version?
Mark
…On Tue, Jul 20, 2021 at 6:09 PM Markus Scherer ***@***.***> wrote:
***@***.**** approved this pull request.
lgtm
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#105 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMELLG2ST47RSMAV74LTYYM4DANCNFSM5AWUEYTQ>
.
|
|
@macchiati On top of U13? I am building a tag now… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #97
This is the only property-specific site that calls setUniformUnassigned that I could find so far, and it's in the JSPs. Should there be a site within the main tools that has
NONCHARACTER_CODE_POINTetc?I'll get this posted somewhere and then work on adding a test.