Skip to content

Conversation

@markusicu
Copy link
Member

... as agreed for all unreleased files, and consistent with the ucd/idna/security/... files.
The emoji files for 15 had been misplaced in PR #232.

Also sync the two data files in the repo that are still duplicated between data/emoji and data/ucd. (See issue #152.)

Also update the two emoji readmes, and
remove the emoji/dev/ReadMe-ucd-emoji.txt which was a copy of ucd/dev/emoji/ReadMe.txt.

... as agreed for all unreleased files, and consistent with the ucd/idna/security/... files.

Also update the two emoji readmes, and
remove the emoji/dev/ReadMe-ucd-emoji.txt which was a copy of ucd/dev/emoji/ReadMe.txt.
Copy link
Contributor

@nedley nedley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review https://github.com/unicode-org/emoji/pull/24 and take that version of emojiOrdering.txt.

@markusicu
Copy link
Member Author

Please review unicode-org/emoji#24 and take that version of emojiOrdering.txt.

For this PR here, I would prefer to just move the existing data files into the right place, rather than also change the data, especially from a pending PR.

Also, I don't see any "ordering" file in the other PR with this name or contents.

I can rubber-stamp https://github.com/unicode-org/emoji/pull/24, if you like, but not much more; and it still has an unresolved negative review from yourself.

@nedley
Copy link
Contributor

nedley commented May 11, 2022

For this PR here, I would prefer to just move the existing data files into the right place, rather than also change the data, especially from a pending PR.

Also, I don't see any "ordering" file in the other PR with this name or contents.

Sigh, there are too many unreviewed PRs in flight… Just do what you have to do.

@markusicu markusicu merged commit 6a045a3 into unicode-org:main May 11, 2022
@markusicu markusicu deleted the move-emoji-15-to-dev branch May 11, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants