-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ASCII fast path from rust-lang #20
Conversation
See rust-lang/rust's `src/librustc_lexer/src/lib.rs` Idea came from unicode-rs#13
Used #21 to verify the performance impact
|
If rustc contains a copy of this code, could efforts be unified? Perhaps with a crate in a new repo in the |
@SimonSapin if I'm reading librustc_lexer, it does pull in this crate. It just added a ascii fast path on top of it. Once librustc_lexer upgrades to a new release of this crate, the fast path will become redundant and could be removed. |
Ah I see, thanks! |
@Manishearth whats the release process for this crate? I'm wondering when I could take advantage of this PR. |
@epage make a PR with a new version, I'll merge and publish |
See rust-lang/rust's
src/librustc_lexer/src/lib.rs
Idea came from #13