Backport qemu/qemu@75b208c #1853
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AFAIK, this is qemu/qemu@75b208c I will backport this accordingly. |
|
Sounds good to me. |
|
@wtdcode Shall I close this PR as you will be back porting directly? or do you want me to update this PR to match the changes from qemu/qemu@75b208c |
|
You could definitely do this (highly welcome!). But please note when you do backport please preserve all origin messages. I did one recently you may refer to: a7a5d18 |
basavesh
changed the title
basavesh
changed the title
basavesh
changed the title
basavesh
changed the title
basavesh
changed the title
basavesh
changed the title
|
I couldn't get the title correct with the hyperlink. I have made the necessary changes with respect to code and the text. |
|
It looks okay but you target the wrong branch. PR always goes to dev. |
|
Closing this as I created an another PR #1861 for dev branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
target/i386: fix operand order for PDEP and PEXT
For PDEP and PEXT, the mask is provided in the memory (mod+r/m)
operand, and therefore is loaded in s->T0 by gen_ldst_modrm.
The source is provided in the second source operand (VEX.vvvv)
and therefore is loaded in s->T1. Fix the order in which
they are passed to the helpers.