Refactor reportAllRunningContainers to use worker goroutines #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to the
core/apps/app_report.go
file to improve the efficiency and reliability of reporting on running containers. The key changes include the addition of concurrency for processing containers, the removal of the ticker, and the introduction of a new helper function to process individual containers.Concurrency improvements:
runtime
andsync
packages to support concurrent processing of containers.sync.WaitGroup
andruntime.NumCPU()
to process containers concurrently.Refactoring and code simplification:
time.Ticker
and replaced it with atime.Sleep
loop to simplify the reporting loop.processReportContainer
to improve code readability and maintainability.Logging and error handling:
continue
.