Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page resources not being loaded from parent nodes #78

Merged
merged 1 commit into from
Jun 7, 2019
Merged

Fix page resources not being loaded from parent nodes #78

merged 1 commit into from
Jun 7, 2019

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Jun 7, 2019

Fixes cases where the page resources are not defined in the page dictionary. Instead they are present in one of the parent nodes of the page.

Addresses #74


This change is Reviewable

@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #78 into development will increase coverage by 5.16%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development      #78      +/-   ##
===============================================
+ Coverage        55.02%   60.18%   +5.16%     
===============================================
  Files              154      154              
  Lines            27976    27974       -2     
===============================================
+ Hits             15393    16836    +1443     
+ Misses           10761    10753       -8     
+ Partials          1822      385    -1437
Impacted Files Coverage Δ
model/page.go 57.78% <100%> (+8.75%) ⬆️
annotator/field_appearance.go 11.62% <0%> (+0.75%) ⬆️
creator/division.go 89.13% <0%> (+1.08%) ⬆️
model/outline.go 86.74% <0%> (+1.2%) ⬆️
model/sighandler/sighandler_rsa_sha1.go 6.02% <0%> (+1.2%) ⬆️
creator/invoice.go 90.07% <0%> (+1.21%) ⬆️
annotator/form_field.go 14.78% <0%> (+1.4%) ⬆️
model/annotations.go 19.12% <0%> (+1.46%) ⬆️
internal/ccittfax/decode.go 94.73% <0%> (+1.5%) ⬆️
creator/toc_line.go 75.39% <0%> (+1.58%) ⬆️
... and 95 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cd5c83...521d1bc. Read the comment docs.

Copy link
Contributor

@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gunnsth gunnsth merged commit 7e56b89 into unidoc:development Jun 7, 2019
@adrg adrg deleted the page-parent-resources branch June 10, 2019 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants