Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to identify Pages nodes without Type #85

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Attempt to identify Pages nodes without Type #85

merged 1 commit into from
Jun 11, 2019

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Jun 11, 2019 •
edited by gunnsth
Loading

Addresses #61

This change is Reviewable

@codecov
Copy link

codecov bot commented Jun 11, 2019 •
edited
Loading

Codecov Report

Merging #85 into development will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development      #85      +/-   ##
===============================================
- Coverage        55.03%   55.02%   -0.01%     
===============================================
  Files              154      154              
  Lines            27981    27985       +4     
===============================================
  Hits             15398    15398              
- Misses           10760    10764       +4     
  Partials          1823     1823
Impacted Files Coverage Δ
model/reader.go 50.84% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4290e33...3292eed. Read the comment docs.

gunnsth
gunnsth approved these changes Jun 11, 2019
View reviewed changes
Copy link
Contributor

@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gunnsth gunnsth merged commit 441e9a3 into unidoc:development Jun 11, 2019
@adrg adrg deleted the pages-missing-type branch June 13, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunnsth gunnsth gunnsth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrg @gunnsth