Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review strictness of comparison of coordinate conversion between SpaceDomain and Variable #54

Open
ThibHlln opened this issue Jul 26, 2021 · 0 comments
Labels
enhancement Improvement of existing feature

Comments

@ThibHlln
Copy link
Member

ThibHlln commented Jul 26, 2021

When working with projected coordinate systems, e.g. BritishNationalGrid, coordinate conversion parameters are provided to allow for the projection of the cartesian coordinates onto standard spherical coordinates (i.e. latitude/longitude in WGS84). At the moment, the list of conversion parameters checked is the one specified in the SpaceDomain itself, which may be more (or less) exhaustive than the list of parameters in the Variable. As soon as there is one parameter in one list that is missing in the other, the Variable will be deemed incompatible with the SpaceDomain.

We need to make sure that the list of parameters we specify in the SpaceDomain is strictly limited to the essential ones, i.e. the ones without which the projection cartesian-to-spherical would not be possible. We could keep the other ones as optional, and only check them if they are in the Variable as well.

In addition to the list, the name of the parameters themselves may be another cause of artificial incompatibility between Variable and SpaceDomain because of the existence of aliases. If the CF-conventions are not specific about the name of those parameters, we may also need to support the use of aliases for the expected conversion parameter names to be more flexible.

@ThibHlln ThibHlln added the enhancement Improvement of existing feature label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing feature
Projects
None yet
Development

No branches or pull requests

1 participant