Remove spacedomain vertical dimension

changelog.rst

@@ -10,6 +10,8 @@ Yet to be versioned and released. Only available from *dev* branch until then.
 * constrain temporal and spatial resolutions of components forming a
   model to be integer multiples of one another
   (`#67 <https://github.com/cm4twc-org/cm4twc/pull/67>`_)
+* enforce two-dimensional spatial domains for components
+  (`#69 <https://github.com/cm4twc-org/cm4twc/pull/69>`_)
 
 .. rubric:: API changes
 
@@ -23,6 +25,9 @@ Yet to be versioned and released. Only available from *dev* branch until then.
   (`#46 <https://github.com/cm4twc-org/cm4twc/pull/46>`_)
 * remove science components (Artemis and RFM) from framework
   (`#45 <https://github.com/cm4twc-org/cm4twc/issues/45>`_)
+* remove vertical dimension (i.e. altitude) in `LatLonGrid`,
+  `RotatedLatLonGrid`, and `BritishNationalGrid`
+  (`#69 <https://github.com/cm4twc-org/cm4twc/pull/69>`_)
 
 .. rubric:: Bug fixes
 

cm4twc/_utils/exchanger.py

@@ -64,7 +64,14 @@ def set_up(self, clock, compass, overwrite=False):
         # set up each transfer
         for t in self.transfers:
             histories = []
-            shape = self.transfers[t]['src_sd'].shape
+
+            # determine shape of transfer while dropping Z axis if
+            # spacedomain is 3D because transfers are along 2D interface
+            shape = (
+                self.transfers[t]['src_sd'].shape[1:]
+                if self.transfers[t]['src_sd'].has_vertical_axis()
+                else self.transfers[t]['src_sd'].shape
+            )
 
             # special case for transfers towards a DataComponent or
             # a NullComponent (or towards outside framework, which will
@@ -88,9 +95,17 @@ def set_up(self, clock, compass, overwrite=False):
                     # to None to avoid unnecessary remapping
                     src_sd = self.transfers[t]['src_sd']
                     src_fld = src_sd.to_field()
-                    dst_fld = compass.spacedomains[c].to_field()
+                    dst_sd = compass.spacedomains[c]
+                    dst_fld = dst_sd.to_field()
+
+                    # eliminate Z axis by squeezing fields because
+                    # remapping for transfers on a 2D interface
+                    if src_sd.has_vertical_axis():
+                        src_fld.squeeze(src_sd.vertical_axis, inplace=True)
+                    if dst_sd.has_vertical_axis():
+                        dst_fld.squeeze(dst_sd.vertical_axis, inplace=True)
 
-                    if src_sd.is_space_equal_to(dst_fld, ignore_z=True):
+                    if src_sd.is_space_equal_to(dst_fld):
                         self.transfers[t][c]['remap'] = None
                     else:
                         # now assign a tuple to 'remap' where first item
@@ -335,7 +350,7 @@ def set_transfer(self, name, array):
         lhs[:] = rhs[:]
 
         self.transfers[name]['slices'][:] = lhs
-        self.transfers[name]['slices'][-1] = array
+        self.transfers[name]['slices'][-1][:] = array
 
     def update_transfers(self, transfers):
         for name, array in transfers.items():
@@ -363,7 +378,15 @@ def create_transfers_dump(filepath, transfers_info, timedomain, spacedomains):
         for c in spacedomains:
             g = f.createGroup(c)
             spacedomain = spacedomains[c]
-            axes = spacedomain.axes
+
+            # drop Z axis if spacedomain is 3D because transfers are
+            # along 2D interface only
+            axes = (
+                spacedomain.axes[1:]
+                if spacedomain.has_vertical_axis()
+                else spacedomain.axes
+            )
+
             # dimensions and coordinate variables
             for axis in axes:
                 # dimension (domain axis)