Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format of public.openTypeMeta #187

Open
schriftgestalt opened this issue Aug 3, 2021 · 8 comments
Open

Format of public.openTypeMeta #187

schriftgestalt opened this issue Aug 3, 2021 · 8 comments
Labels

Comments

@schriftgestalt
Copy link

I think public.openTypeMeta should contain a list instead a dict. See: fonttools/fonttools#2345

@benkiel
Copy link
Contributor

benkiel commented Jan 21, 2022

@moyogo this was your part of the spec: are you ok with this being a list and not a dict?

@benkiel benkiel added bug ufo4 UFO 4 issues. and removed ufo4 UFO 4 issues. labels Jan 21, 2022
@benkiel
Copy link
Contributor

benkiel commented Jan 21, 2022

(also, would this would be a breaking change, so we'd need to put it in UFO4, no?)

@moyogo
Copy link
Collaborator

moyogo commented Feb 8, 2022

@benkiel yes, @schriftgestalt is correct. It should have been a dict [Edit: list].

@schriftgestalt
Copy link
Author

(Just to be clear, it should be a list, not a dict.)

@benkiel
Copy link
Contributor

benkiel commented Jul 5, 2023

@moyogo @anthrotype Looking back at this, because it's a public key, I don't think we need to do it in UFO4, but this would be breaking to go to list. Would you be ok with changing the definition here now, or would you rather wait for a UFO number bump?

@anthrotype
Copy link
Member

I'd vote to wait for version bump since I haven't seen concrete use cases for the duplicate tags yet, and breaking existing projects would be worse

@anthrotype
Copy link
Member

anthrotype commented Jul 5, 2023

and fonttools meta implementation hasn't been fixed either...

@benkiel
Copy link
Contributor

benkiel commented Jul 5, 2023

Got it. Cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants