Support "meta Table" custom parameter #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthrotype
approved these changes
Sep 15, 2022
| def to_ufo_meta_table(value): | ||
| meta = {} | ||
| # In: {data = "de-Latn"; tag = dlng; }, {data = "sr-Cyrl"; tag = slng; } | ||
| # Out: { "dlng": [ "de-Latn" ], "slng": [ "sr-Cyrl" ] } |
There was a problem hiding this comment.
fonttools and UFO spec currently store meta data as a dictionary thus disallowing entries with duplicate keys, whereas Glyphs.app follows OT spec and allows that:
fonttools/fonttools#2345
unified-font-object/ufo-spec#187
Maybe that will change if somebody bothers to change that, but for now that's how it is, I suggest you log a warning in the case of duplicate keys. Right now you are taking the last, either that or taking first is fine, both are equally "wrong" anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #693.