Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make coveralls run parallel #77

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make coveralls run parallel #77

wants to merge 2 commits into from

Conversation

benkiel
Copy link
Contributor

@benkiel benkiel commented Dec 6, 2020

No description provided.

@benkiel
Copy link
Contributor Author

benkiel commented Dec 6, 2020

Well, that quick attempt isn't working, will come back to later.

@miguelsousa
Copy link
Member

We've been using Codecov.io for a while and it has worked well for afdko and psautohint. Consider dropping Coveralls in favor of that.

@miguelsousa
Copy link
Member

Also, making coverage run in parallel might be as simple as adding a line with parallel = True to the repo's .coveragerc file.

@josh-hadley
Copy link
Collaborator

josh-hadley commented Dec 8, 2020

This might be of use: https://github.com/marketplace/actions/coveralls-github-action

Edit: Oh, duh that's what you have, nevermind 🤭

It looks like the Action expects the coverage file(s) to be ./coverage/lcov.info but I believe the test command coverage run setup.py test is going to put the results into .coverage. You could try changing the Action's path-to-lcov param to .coverage instead.

If that doesn't work: looks like someone has created a coveralls action specifically for Python's coverage: https://github.com/marketplace/actions/coveralls-python

@josh-hadley
Copy link
Collaborator

Looks like that expects an actual LCOV file. Maybe let's look at that Python-specific coveralls action, or switch to codecov.io as Miguel suggested?

@benkiel
Copy link
Contributor Author

benkiel commented Dec 9, 2020

Yup, will switch to codecov.io that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants