Make sure images come through #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simple fix ensures that image file names are actually recognized as such.
|
Thank you 100000x for this, fixing this has been on my todo list for way too long |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former
imageFileRef[:]notation would change a file name (e.g.image.png) to['i', 'm', 'a', 'g', 'e', '.', 'p', 'n', 'g'].Downstream in
imageFileName = imageFileRef[0] if imageFileRef else Nonethis was passed on asi– and therefore not recognized as an image.Finally, in
imagesToPurge = availableImages - referencedImages, the available images were actual image paths, while referenced images were just strings likea,b,c– this means that all images were just flushed.I’ve tested with my own data and the UFO in #65 – both work.
I also tested using a UFO with multiple images, which also works fine.