Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dtslint silently started failing #71

Closed
wooorm opened this issue Oct 1, 2019 · 0 comments · Fixed by #72
Closed

dtslint silently started failing #71

wooorm opened this issue Oct 1, 2019 · 0 comments · Fixed by #72
Labels
🏡 area/internal This affects the hidden internals ☂️ area/types This affects typings 💪 phase/solved Post is done 🐛 type/bug This is a problem

Comments

@wooorm
Copy link
Member

wooorm commented Oct 1, 2019

Subject of the issue

dtslint currently fails:

> unified@8.4.0 test-types unified
> dtslint types

Error: unified/types/index.d.ts:3:1
ERROR: 3:1     strict-export-declare-modifiers  All declarations in this module are exported automatically. Prefer to explicitly write 'export' for clarity. If you have a good reason not to export this declaration, add 'export {}' to the module to shut off automatic exporting. See: https://github.com/Microsoft/dtslint/blob/master/docs/strict-export-declare-modifiers.md
ERROR: 4:1     strict-export-declare-modifiers  All declarations in this module are exported automatically. Prefer to explicitly write 'export' for clarity. If you have a good reason not to export this declaration, add 'export {}' to the module to shut off automatic exporting. See: https://github.com/Microsoft/dtslint/blob/master/docs/strict-export-declare-modifiers.md
ERROR: 5:8     strict-export-declare-modifiers  All declarations in this module are exported automatically. Prefer to explicitly write 'export' for clarity. If you have a good reason not to export this declaration, add 'export {}' to the module to shut off automatic exporting. See: https://github.com/Microsoft/dtslint/blob/master/docs/strict-export-declare-modifiers.md
ERROR: 7:19    strict-export-declare-modifiers  All declarations in this module are exported automatically. Prefer to explicitly write 'export' for clarity. If you have a good reason not to export this declaration, add 'export {}' to the module to shut off automatic exporting. See: https://github.com/Microsoft/dtslint/blob/master/docs/strict-export-declare-modifiers.md
ERROR: 412:18  strict-export-declare-modifiers  All declarations in this module are exported automatically. Prefer to explicitly write 'export' for clarity. If you have a good reason not to export this declaration, add 'export {}' to the module to shut off automatic exporting. See: https://github.com/Microsoft/dtslint/blob/master/docs/strict-export-declare-modifiers.md
ERROR: 413:1   strict-export-declare-modifiers  All declarations in this module are exported automatically. Prefer to explicitly write 'export' for clarity. If you have a good reason not to export this declaration, add 'export {}' to the module to shut off automatic exporting. See: https://github.com/Microsoft/dtslint/blob/master/docs/strict-export-declare-modifiers.md

Your environment

  • OS: macOS Mojave 10.14.6
  • Packages: latest
  • Env: Node 12.2, npm 6.11

Steps to reproduce

git clone, npm install, and npm test.

Expected behaviour

Shouldn’t fail

Actual behaviour

Fails

/cc @ChristianMurphy @Rokt33r

@wooorm wooorm added 🐛 type/bug This is a problem ☂️ area/types This affects typings 🙆 yes/confirmed This is confirmed and ready to be worked on 🏡 area/internal This affects the hidden internals labels Oct 1, 2019
ChristianMurphy added a commit to ChristianMurphy/unified that referenced this issue Oct 1, 2019
@wooorm wooorm closed this as completed in #72 Oct 2, 2019
wooorm pushed a commit that referenced this issue Oct 2, 2019
Closes GH-71.
Closes GH-72.

Reviewed-by: Junyoung Choi <fluke8259@gmail.com>
Reviewed-by: Titus Wormer <tituswormer@gmail.com>
@wooorm wooorm added ⛵️ status/released and removed 🙆 yes/confirmed This is confirmed and ready to be worked on labels Oct 2, 2019
@wooorm wooorm added the 💪 phase/solved Post is done label May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏡 area/internal This affects the hidden internals ☂️ area/types This affects typings 💪 phase/solved Post is done 🐛 type/bug This is a problem
Development

Successfully merging a pull request may close this issue.

1 participant