Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with AWS provider v1.25 #32

Closed
edahlseng opened this issue Jul 3, 2018 · 0 comments
Closed

Problem with AWS provider v1.25 #32

edahlseng opened this issue Jul 3, 2018 · 0 comments
Assignees
@disaac
Labels
bug

Comments

@edahlseng
Copy link
Contributor

When using AWS provider version ~> v1.25.0, the following error is generated:

Error: module.vpc_base.aws_vpc.vpc: expected instance_tenancy to be one of [default dedicated], got

(the error message is awkwardly cut off with no further information, as shown above)

Using AWS provider version ~> v1.24.0 works.

Notes on this issue from @disaac:

Yeah its from starting to use the stringslice validation function
https://github.com/terraform-providers/terraform-provider-aws/blob/34d3d23fa5f6db073e3bba4903e582ad905e1e94/aws/resource_aws_vpc.go#L42-L43
https://github.com/terraform-providers/terraform-provider-aws/blob/34d3d23fa5f6db073e3bba4903e582ad905e1e94/vendor/github.com/hashicorp/terraform/helper/validation/validation.go#L76-L94
disaac added a commit that referenced this issue Jul 11, 2018
@disaac
#32 Support aws provider instance_tenancy value
98366d0 
#### Description
[Issue #32](#32)

* Instance tenancy now uses validation.StringInSlice so a value must be supplied.
* Created a local value to store the instance_tenancy if a value is supplied otherwise sets it to the default value to avoid suplying an empty value which is no longer supported.
disaac added a commit that referenced this issue Jul 11, 2018
@disaac
#32 Support aws provider instance_tenancy value
cf717e2 
#### Description
[Issue #32](#32)

* Instance tenancy now uses validation.StringInSlice so a value must be supplied.
* Created a local value to store the instance_tenancy if a value is supplied otherwise sets it to the default value to avoid suplying an empty value which is no longer supported.
disaac added a commit that referenced this issue Jul 11, 2018
@disaac
#32 Support aws provider instance_tenancy value
c276eaa 
#### Description
[Issue #32](#32)

* Instance tenancy now uses validation.StringInSlice so a value must be supplied.
* Created a local value to store the instance_tenancy if a value is supplied otherwise sets it to the default value to avoid supplying an empty value which is no longer supported.
@disaac disaac mentioned this issue Jul 11, 2018
Merged
@disaac disaac self-assigned this Jul 11, 2018
@disaac disaac added the bug label Jul 11, 2018
disaac added a commit that referenced this issue Jul 11, 2018
@disaac
Merge pull request #33 from unifio/issue32-instance_tenancy_aws_provi…
7580cdc 
…der_fix

#32 Support aws provider instance_tenancy value
@disaac disaac closed this as completed Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@disaac disaac

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edahlseng @disaac