-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terraform 0.12 support #44
Open
disaac
wants to merge
23
commits into
master
Choose a base branch
from
upgrade-0.12
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 74c36ccd05fb038db21983517cbb64f8d54e252f.
[DEVOPS-2273] Static subnet support
This reverts commit 54768d6.
* Added .env.covalence for local testing outside circleci * Updated hiera to use alias instead hiera. * Updated Version in changelog to 0.4.0 for TF v0.12 upgrade listed incompatibilities. * Removed TF 11 version constraint from module since it is defined in versions.tf file. * Ran bin/covalence all:format to format all of the TF files after updates.
* Set types to bool for TF 12 support in ci.
* Updated README to reflect true default of enable_dns_hostnames which uses the module variable enable_hostnames. The true default is false. * Updated examples to properly use the order of opperations to multiple the returned value by the nat_gateways_enabled variable. After automated conversion to support terraform 0.12 the total was not being multiplied by the return of the signum of the nat_gateways_enabled check in count. * Updated the state bucket to use a new state bucket created in the unifio uat aws account. * Updated the region to be us-east-1 since its in a new account. * Updated boolean flag values to be converted to true boolean or null if empty string provided. Allows default behavior but uses a local variable instead of the supplied module variable. `var.enable_dns` `var.enable_hostnames` `var.enable_classiclink` `enable_dmz_public_ips` . Prior to update ci tests would fail due to the bool values being expected.
* Updated the container used to the most recent automated build of dockerfile-ci
* Added local definitions for variables that are interpreted as bools by resources. * Check for empty values and set to null when empty or convert string bool when not empty.
* removing the quotes grom count result so that count functions properly.
* Updated the covalence ci image to the latest which uses Terraform 0.12.29
This was referenced Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module updates for terraform 0.12 support