Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow subnet specific tags #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cristobal23
Copy link
Contributor

@cristobal23 cristobal23 commented Jul 22, 2021

This pull request adds a couple more variables (additional_dmz_tags & additional_lan_tags) to the az terraform module. By adding these additional tags, we can differentiate between dmz and lan subnets.

An example use case for this feature is; suppose we want to create a VPC for an AWS EKS cluster. Defining these additional tags allows one to control where Elastic Load Balancers are provisioned. See Cluster VPC considerations in the AWS documentation.

Here is an example of possible data values:

terraform::vpc::vars:
  additional_dmz_tags: { "kubernetes.io/role/elb": "1" }
  additional_lan_tags: { "kubernetes.io/role/internal-elb": "1" }
  additional_subnet_tags: { "kubernetes.io/cluster/%{hiera('env_label')}": "shared" }

This commit allows the use of tags that are specific to the dmz and tags that
are specific to the lan.
@cristobal23 cristobal23 marked this pull request as ready for review July 23, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant