Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update About Page #133

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update About Page #133

wants to merge 3 commits into from

Conversation

nick-ang
Copy link
Contributor

@nick-ang nick-ang commented Dec 18, 2021

https://www.notion.so/unihack/Update-our-About-Us-page-793a4db7c5b94be08bd333208a84f883

Tried to match above design as close as possible

Things to note:

Where should the Join the team and diversity scholarship buttons link to?
Cant seem to get the img borders working, there is a border none which seems to override it and I cant find where it is

@vercel
Copy link

vercel bot commented Dec 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/unihack/unihack-website/BgDpMWgrsVjRTMKhFwoBosZFCBaP
✅ Preview: https://unihack-website-git-about-unihack.vercel.app

@nick-ang nick-ang requested review from a team and terencehuynh December 18, 2021 04:59
@terencehuynh
Copy link
Member

  1. Diversity Scholarship link is TBD - let's leave it for now (or comment it out and add a TODO to revisit once we get the link from Sponsorship)
  2. The image borders issue - can you tell me what's happening or let's have a few minutes to pair on it so I can see what's happening. It'll most likely be a CSS issue.

@nick-ang

@nick-ang
Copy link
Contributor Author

  1. Diversity Scholarship link is TBD - let's leave it for now (or comment it out and add a TODO to revisit once we get the link from Sponsorship)
  2. The image borders issue - can you tell me what's happening or let's have a few minutes to pair on it so I can see what's happening. It'll most likely be a CSS issue.

@nick-ang

Ok thanks will make that change.

I think it might be something to do with this border: none -

image

When I uncheck it the border comes through but I cant seem to find it in the code. Maybe I can quickly show you at the party today?

Copy link
Member

@terencehuynh terencehuynh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes - plus what I think is the issue with the images

components/team/team.tsx Show resolved Hide resolved
sections/about-us/about-us.module.scss Outdated Show resolved Hide resolved
sections/about-hero/about-hero.module.scss Show resolved Hide resolved
sections/stats/stats.module.scss Show resolved Hide resolved
@nick-ang nick-ang marked this pull request as ready for review December 30, 2021 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants