Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce v0.19 of vCluster #160

Closed
wants to merge 1 commit into from
Closed

Re-introduce v0.19 of vCluster #160

wants to merge 1 commit into from

Conversation

yankcrime
Copy link
Member

@yankcrime yankcrime commented Dec 17, 2024

Essentially revert 14e70f2, and introduce a new clustermanagerapplicationbundle version so that existing Cluster Managers can still be managed without having to be destroyed.

@spjmurray
Copy link
Member

sigh we'll need a breaking change flag in the CRD to prevent auto upgrade from doing bad things then

@drew-viles
Copy link
Contributor

drew-viles commented Dec 17, 2024

Would it not make more sense to have 1.0.0 left as 0.19.5 for vcluster.

We can "turn off" sync for the dev cluster, bump the cluster mangaer up and then resync which will leave that one as it is and then it means that prod needs no action essentially?

Not sure if that is feasible of course but might be the safer approach to do it on dev rather than making a potentially breaking change action to prod?

@yankcrime
Copy link
Member Author

Yeah it's six of one, half a dozen of the other since we'd have the opposite problem in dev. Let's discuss remediation in Slack.

Essentially revert 14e70f2, but introduce a new
clustermanagerapplicationbundle version so that existing Cluster
Managers can still be managed without having to be destroyed.
@spjmurray
Copy link
Member

spjmurray commented Jan 2, 2025

Okay, here's how it's gonna go down. The vcluster upgrade was a breaking change, and we don't want that kind of accident to happen in production causing irreparable damage. As I say, auto upgrade is a problem here that needs solving, as per #162. So you have two options, You can either have one bundle as v0.x.x and the other as v1.x.x, or one as v1.x.x and the other v2.x.x. Problem one solved.

Which you select is up to you, and will probably be dependent on which is going to cause the least pain... said pain means that some cluster managers will need to be manually updated to a non-existent bundle version (this will error and cause no harm), then you can perform the upgrade and they'll start reconciling again.

Given the new vcluster has been in the wild for a relatively long time now, I'd suggest reinstating the old vcluster as a v0.1.0 bundle, changing the cluster manager that is still using this version's application bundle to that v0.1.0 and then upgrading. Obviously test test test in isolation first and get back to me before we think about merging and releasing.

@yankcrime
Copy link
Member Author

Closing in favour of an alternative approach.

@yankcrime yankcrime closed this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants