feat: Add KraftKit contributing page
#380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Seritan <luca.seritan@gmail.com>
LucaSeri
force-pushed
the
kraft-contributing
branch
2 times, most recently
from
26c2f15
to
dd0a81b
Compare
StefanJum
requested changes
Mar 2, 2024
This page is largely based on the Unikraft core contributing page and contains details about the conventions used in KraftKit. Signed-off-by: Luca Seritan <luca.seritan@gmail.com>
LucaSeri
force-pushed
the
kraft-contributing
branch
from
dd0a81b
to
b39b14a
Compare
|
Thanks for the review @StefanJum, I added your suggested changes.
I linked |
StefanJum
approved these changes
Mar 2, 2024
There was a problem hiding this comment.
I linked gofumpt, their readme provides a bunch of examples about the rules, please check if you think that's enough.
It's perfect.
All good now, thanks.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
razvand
approved these changes
Mar 2, 2024
There was a problem hiding this comment.
Thanks, @LucaSeri
Approved-by: Razvan Deaconescu razvand@unikraft.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
KraftKitcontributing page has the same format as theUnikraft corecontributing page, which has been modified to reflect the conventions used in theKraftKitdevelopment.GitHub-fixes: #370