Skip to content
This repository has been archived by the owner on Jul 17, 2023. It is now read-only.

Resolve out of range error #82

Closed

Conversation

gabrielmocanu
Copy link
Member

@gabrielmocanu gabrielmocanu commented Oct 30, 2021

Add a check for out of range error if the name of the base directory is different from the name of the application from kraft.yaml.

Github-Pull-Request-Closes: #80
Signed-off-by: Gabriel Mocanu gabi.mocanu98@gmail.com

…is different from the name of the application from kraft.yaml

Signed-off-by: Gabriel Mocanu <gabi.mocanu98@gmail.com>
@razvand razvand requested a review from StefanJum January 22, 2022 08:10
@razvand razvand self-assigned this Jan 22, 2022
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some layout / wording suggestions.

kraft/cmd/run.py Outdated Show resolved Hide resolved
kraft/cmd/run.py Outdated Show resolved Hide resolved
Co-authored-by: Razvan Deaconescu <razvan@rosedu.org>
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using kraft up -t helloworld different-name-dir this does not work, since the if on this line is not taken, and target is set here.
Works fine with kraft run.

@gabrielmocanu
Copy link
Member Author

gabrielmocanu commented Mar 19, 2022

I closed this PR since this one fixed the issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Status: review:invalid
Development

Successfully merging this pull request may close these issues.

Kraft failes with list index out of range
3 participants