Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "drop_invalid_rows" settings from missing from (de)serialisation #1743

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hugolytics
Copy link

No description provided.

@cosmicBboy
Copy link
Collaborator

thanks for the contribution @hugolytics!

would you mind following the steps here to make the DCO check pass?

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.84%. Comparing base (812b2a8) to head (dd5f45c).
Report is 127 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (812b2a8) and HEAD (dd5f45c). Click for more details.

HEAD has 11 uploads less than BASE
Flag BASE (812b2a8) HEAD (dd5f45c)
48 37
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1743       +/-   ##
===========================================
- Coverage   94.28%   59.84%   -34.44%     
===========================================
  Files          91      117       +26     
  Lines        7013     8864     +1851     
===========================================
- Hits         6612     5305     -1307     
- Misses        401     3559     +3158     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
@cosmicBboy
Copy link
Collaborator

looks like there's a failing test: https://github.com/unionai-oss/pandera/actions/runs/9997112318/job/27632935647?pr=1743

Please follow the instructions here to run the tests locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants