Create empty dataframe from Pandas DataFrame Model #1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamo3gr
force-pushed
the
feature/create-empty-dataframe
branch
2 times, most recently
from
8fd96a3 to
c54b556
Compare
Signed-off-by: Mamoru Miura <mamo3gr@gmail.com>
mamo3gr
force-pushed
the
feature/create-empty-dataframe
branch
from
c54b556 to
918abf7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1880 +/- ##
==========================================
- Coverage 94.28% 93.26% -1.02%
==========================================
Files 91 121 +30
Lines 7013 9299 +2286
==========================================
+ Hits 6612 8673 +2061
- Misses 401 626 +225 ☔ View full report in Codecov by Sentry. |
cosmicBboy
requested changes
Dec 27, 2024
pandera/api/dataframe/model.py
Outdated
| @@ -20,6 +20,8 @@ | |||
| cast, | |||
| ) | |||
|
|
|||
| import pandas as pd | |||
There was a problem hiding this comment.
the generic dataframe.model module should not depend on any dataframe library, can you move this to https://github.com/unionai-oss/pandera/blob/main/pandera/api/pandas/model.py?
There was a problem hiding this comment.
Sure. I have done it with 38a5a95.
Signed-off-by: Mamoru Miura <mamo3gr@gmail.com>
Signed-off-by: Mamoru Miura <mamo3gr@gmail.com>
mamo3gr
force-pushed
the
feature/create-empty-dataframe
branch
from
11aef4d to
fb1ac6a
Compare
mamo3gr
changed the title
mamo3gr
force-pushed
the
feature/create-empty-dataframe
branch
from
cfef591 to
d4987ac
Compare
Signed-off-by: Mamoru Miura <mamo3gr@gmail.com>
mamo3gr
force-pushed
the
feature/create-empty-dataframe
branch
from
d4987ac to
bd42149
Compare
cosmicBboy
approved these changes
Dec 31, 2024
|
thanks @mamo3gr ! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm interested in #1039 however it has not been merged. I would like to salvage the PR partially (temporarily), that is, only for DataFrame Model.