-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement minimal built-in checks for Ibis backend #1885
Open
deepyaman
wants to merge
7
commits into
unionai-oss:ibis-dev
Choose a base branch
from
deepyaman:feat/ibis/builtin-checks
base: ibis-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Implement minimal built-in checks for Ibis backend #1885
deepyaman
wants to merge
7
commits into
unionai-oss:ibis-dev
from
deepyaman:feat/ibis/builtin-checks
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ibis-dev #1885 +/- ##
============================================
+ Coverage 92.76% 92.91% +0.14%
============================================
Files 133 134 +1
Lines 9705 9722 +17
============================================
+ Hits 9003 9033 +30
+ Misses 702 689 -13 ☔ View full report in Codecov by Sentry. |
deepyaman
force-pushed
the
feat/ibis/builtin-checks
branch
2 times, most recently
from
December 26, 2024 12:38
3d0efc6
to
da8490f
Compare
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
deepyaman
force-pushed
the
feat/ibis/builtin-checks
branch
from
December 31, 2024 12:51
da8490f
to
5744a4c
Compare
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
deepyaman
force-pushed
the
feat/ibis/builtin-checks
branch
from
January 6, 2025 14:14
3f3f649
to
b97d493
Compare
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the built-in check machinery and a single validation (
equal_to
). In future PRs, I (or somebody else) can: