fix empty SchemaModel #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #434 +/- ##
=======================================
Coverage 99.32% 99.33%
=======================================
Files 21 21
Lines 2537 2539 +2
=======================================
+ Hits 2520 2522 +2
Misses 17 17
Continue to review full report at Codecov.
|
3 tasks
cosmicBboy
added a commit
that referenced
this pull request
Mar 27, 2021
* fix DataFrameSchema comparison with non-DataFrameSchema (#431) * increase cache version * fix DataFrameSchema comparison with non-DataFrameSchema * fix pylint error Co-authored-by: cosmicBboy <niels.bantilan@gmail.com> * add doc about attributes excluded by SchemaModel (#436) * fix empty SchemaModel (#434) * fix empty data type not supported for serialization (#435) * Fix to_yaml serialization dropping global checks (#428) * increase cache version * ci: add dataframe checks tests * bugfix: allow serialization of dataframe checks to_yaml * ci: add test to ensure serialization of lambda check fails * bugfix: ensure checks with no parameters generate appropriate schema * wip: allow looking up registered checks * fix: compare checks by name rather than by object equality * ci: black * ci: lint * enh: use REGISTERED_CUSTOM_CHECKS for attribute lookup, add dir method * enh: add to_yaml method to Schema, add unit test * ci: disable typechecking on _CheckMeta * ci: isort * ci: doctests * ci: improve coverage * ci: codecov In these lines, dataframe_checks cannot be None based on the call condition. * fix unrecognized check dtype during (de)serialization * fix handle_stat__dtype closures * enh: move metaclass onto _CheckBase * ci: add test that ensures to_yaml warns on unregistered checks * ci: revert adding duplicate test Co-authored-by: cosmicBboy <niels.bantilan@gmail.com> Co-authored-by: Jean-Francois Zinque <jzinque@gmail.com> * remove unnecessary warnings (#441) since parse_checks handles cases of unregistered checks, the parts of the io module that raised a user warning were are never in the execution path and therefore never covered in tests * bugfix: preserve pandas extension types during validation (#443) * Update docs (#444) * update docs theme to Furo light * add furo * update styles * add favicon, update style Co-authored-by: Jean-Francois Zinque <jzinque@gmail.com> Co-authored-by: Anton Loukianov <anton.loukianov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #433
This PR fixes a bug with empty
SchemaModelraising a TypeError.The problem comes from
__annotationsreturning its super's annotations (i.eSchemaModel) if the class doesn't have annotations itself.Configis then misinterpreted as a missing field and overwritten.