Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: basic user manager comments #77

Merged
merged 3 commits into from
Mar 4, 2022

Conversation

GeraldHost
Copy link
Contributor

Added most basic comments for User Manager contract.

/**
* @dev get frozen coin age
* @param staker address of the staker
* @param pastBlocks past blocks
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need better clarification on exactly what these past blocks are.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the number of blocks since overdue.

/**
* @dev get frozen coin age
* @param staker address of the staker
* @param pastBlocks past blocks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the number of blocks since overdue.

# Conflicts:
#	contracts/user/UserManager.sol
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #77 (0fa3185) into master (68b5476) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #77    +/-   ##
=======================================
  Coverage    0.00%   0.00%            
=======================================
  Files          19      24     +5     
  Lines        1419    1525   +106     
  Branches      234     250    +16     
=======================================
- Misses       1419    1525   +106     
Impacted Files Coverage Δ
contracts/Controller.sol 0.00% <ø> (ø)
contracts/UUPSProxy.sol 0.00% <ø> (ø)
contracts/WadRayMath.sol 0.00% <ø> (ø)
contracts/asset/AaveAdapter.sol 0.00% <ø> (ø)
contracts/asset/AssetManager.sol 0.00% <ø> (ø)
contracts/asset/CompoundAdapter.sol 0.00% <ø> (ø)
contracts/asset/PureTokenAdapter.sol 0.00% <ø> (ø)
contracts/governance/UnionGovernor.sol 0.00% <ø> (ø)
contracts/market/FixedInterestRateModel.sol 0.00% <ø> (ø)
contracts/market/MarketRegistry.sol 0.00% <ø> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c68f939...0fa3185. Read the comment docs.

@maxweng maxweng merged commit 9b56085 into master Mar 4, 2022
@maxweng maxweng deleted the docs/basic-user-manager-comments branch March 4, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants