Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test coverage reporting bugs #96

Merged
merged 2 commits into from
Mar 25, 2022

Conversation

maxweng
Copy link
Member

@maxweng maxweng commented Mar 24, 2022

No description provided.

@linear
Copy link

linear bot commented Mar 24, 2022

@maxweng maxweng requested a review from twygod March 24, 2022 13:25
@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #96 (10636f6) into master (68b5476) will increase coverage by 89.90%.
The diff coverage is 23.36%.

❗ Current head 10636f6 differs from pull request most recent head 1903c4d. Consider uploading reports for the commit 1903c4d to get more accurate results

@@             Coverage Diff             @@
##           master      #96       +/-   ##
===========================================
+ Coverage    0.00%   89.90%   +89.90%     
===========================================
  Files          19       24        +5     
  Lines        1419     1525      +106     
  Branches      234      250       +16     
===========================================
+ Hits            0     1371     +1371     
+ Misses       1419      154     -1265     
Impacted Files Coverage Δ
contracts/Controller.sol 97.50% <ø> (+97.50%) ⬆️
contracts/UUPSProxy.sol 0.00% <ø> (ø)
contracts/WadRayMath.sol 100.00% <ø> (+100.00%) ⬆️
contracts/asset/AaveAdapter.sol 90.90% <ø> (+90.90%) ⬆️
contracts/asset/AssetManager.sol 96.58% <ø> (+96.58%) ⬆️
contracts/asset/CompoundAdapter.sol 97.50% <ø> (+97.50%) ⬆️
contracts/asset/PureTokenAdapter.sol 87.80% <ø> (+87.80%) ⬆️
contracts/governance/UnionGovernor.sol 87.80% <ø> (+87.80%) ⬆️
contracts/market/FixedInterestRateModel.sol 100.00% <ø> (+100.00%) ⬆️
contracts/market/MarketRegistry.sol 100.00% <ø> (+100.00%) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3fbb6f...1903c4d. Read the comment docs.

@maxweng maxweng merged commit 048fdea into master Mar 25, 2022
@maxweng maxweng deleted the feature/uni-636-fix-test-coverage-reporting-bugs branch March 25, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants