UNI-1030 check reverted when one of the adapters is broken or paused.

[twygod]

No description provided.

[linear]

UNI-1030 #37 - Asset manager's deposit, withdraw and rebalance function calls will get reverted when one of the adapters is broken or paused

sherlock-audit/2022-10-union-finance-judging#37

[dupe: 129]

[maxweng]

@twygod do you think we can add an integration/simulation test here to make sure the changes will work when the underlying lending market failed?

[twygod]

underlying lending market failed

I don't think it is necessary. We only need to test whether the assetmanager is executed correctly when the underlying lending market failed. The unit test is enough

[dmitriia]

Looks ok.

Notice that now all the distribution that failed to be allocated with deposit() will go to the very last strategy:

union-v2-contracts/contracts/asset/AssetManager.sol

Lines 531 to 547 in 49d1a72

	uint256 tokenSupply = token.balanceOf(address(this));
	for (uint256 i = 0; i < percentagesLength; i++) {
	IMoneyMarketAdapter moneyMarket = supportedMoneyMarkets[i];
	uint256 amountToDeposit = (tokenSupply * percentages[i]) / 10000;
	if (amountToDeposit == 0) continue;
	token.safeTransfer(address(moneyMarket), amountToDeposit);
	moneyMarket.deposit(tokenAddress);
	}
	uint256 remainingTokens = token.balanceOf(address(this));
	IMoneyMarketAdapter lastMoneyMarket = supportedMoneyMarkets[supportedMoneyMarketsSize - 1];
	if (remainingTokens > 0) {
	token.safeTransfer(address(lastMoneyMarket), remainingTokens);
	lastMoneyMarket.deposit(tokenAddress);
	}

        uint256 tokenSupply = token.balanceOf(address(this));

        for (uint256 i = 0; i < percentagesLength; i++) {
            IMoneyMarketAdapter moneyMarket = supportedMoneyMarkets[i];
            uint256 amountToDeposit = (tokenSupply * percentages[i]) / 10000;
            if (amountToDeposit == 0) continue;
            token.safeTransfer(address(moneyMarket), amountToDeposit);
            moneyMarket.deposit(tokenAddress);
        }

        uint256 remainingTokens = token.balanceOf(address(this));

        IMoneyMarketAdapter lastMoneyMarket = supportedMoneyMarkets[supportedMoneyMarketsSize - 1];
        if (remainingTokens > 0) {
            token.safeTransfer(address(lastMoneyMarket), remainingTokens);
            lastMoneyMarket.deposit(tokenAddress);
        }

I.e. when moneyMarket.deposit(tokenAddress) fails and return false it isn't treated on the spot with some kind of redistribution, but all the unallocated funds will go to the last strategy.