Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize cometbls groth16 verifier #1378

Closed
hussein-aitlahcen opened this issue Feb 15, 2024 · 2 comments · Fixed by #1770
Closed

Optimize cometbls groth16 verifier #1378

hussein-aitlahcen opened this issue Feb 15, 2024 · 2 comments · Fixed by #1770
Assignees
@aeryz
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@hussein-aitlahcen
Copy link
Contributor

Optimize the verifier not to recompute alpha_g1_beta_g2. Use precomputed values like in the solidity verifier.
@hussein-aitlahcen hussein-aitlahcen added C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Feb 15, 2024
@benluelo
Copy link
Contributor

depending on what needs to be computed, this may need to be a build script (similar to the poseidon implementation)

@hussein-aitlahcen hussein-aitlahcen mentioned this issue Apr 4, 2024
Open
@benluelo benluelo removed the E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. label Apr 5, 2024
@aeryz
Copy link
Contributor

aeryz commented Apr 17, 2024

Depends on #1769

@aeryz aeryz added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Apr 17, 2024
@aeryz aeryz self-assigned this Apr 23, 2024
@aeryz aeryz mentioned this issue Apr 23, 2024
Merged
@aeryz aeryz closed this as completed in 9fe822b Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeryz aeryz

Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: introduce gnark-key-parser unionlabs/union
3 participants
@hussein-aitlahcen @aeryz @benluelo