upgrade gnark/mpc tools #2579
Open
upgrade gnark/mpc tools #2579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hussein-aitlahcen
force-pushed
the
upgrade-gnark-mpc
branch
from
09fa1d8
to
43019fd
Compare
hussein-aitlahcen
temporarily deployed
to
app-preview
GitHub Actions
Inactive
App 🤌🌎 Deploying... |
hussein-aitlahcen
temporarily deployed
to
app-preview
GitHub Actions
Inactive
benluelo
reviewed
Jul 30, 2024
hussein-aitlahcen
temporarily deployed
to
app-preview
GitHub Actions
Inactive
hussein-aitlahcen
force-pushed
the
upgrade-gnark-mpc
branch
2 times, most recently
from
5fdf997
to
9f97236
Compare
hussein-aitlahcen
temporarily deployed
to
app-preview
GitHub Actions
Inactive
hussein-aitlahcen
force-pushed
the
upgrade-gnark-mpc
branch
from
c7eee4a
to
723fad4
Compare
|
Awaiting Consensys/gnark#1230 to rebase and merge. |
hussein-aitlahcen
force-pushed
the
upgrade-gnark-mpc
branch
from
2e2c90b
to
d396e24
Compare
hussein-aitlahcen
force-pushed
the
upgrade-gnark-mpc
branch
from
99afd08
to
64ce6d8
Compare
hussein-aitlahcen
force-pushed
the
upgrade-gnark-mpc
branch
3 times, most recently
from
8c88160
to
9e20456
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
hussein-aitlahcen
force-pushed
the
upgrade-gnark-mpc
branch
from
c31af66
to
5082157
Compare
benluelo
reviewed
Sep 20, 2024
|
|
||
| This project contains the client and coordinator to conduct Groth16 multi-party computation for the circuit SRS. | ||
| Three components are in play: | ||
| - Supabase : host the state machine in postgresql and exposes api and storage services to upload contributions. |
There was a problem hiding this comment.
Suggested change
| - Supabase : host the state machine in postgresql and exposes api and storage services to upload contributions. | |
| - Supabase: host the state machine in postgresql and exposes api and storage services to upload contributions. |
| - `POST /contribute` a `Contribute` object in body. Returns : | ||
| - a `202 Accepted` if the contribution started. | ||
| - a `503 Unavailable` if the client is busy (likely already contributing). | ||
| - `GET /contribute` returns : |
There was a problem hiding this comment.
Suggested change
| - `GET /contribute` returns : | |
| - `GET /contribute` returns: |
| if is_already_successful().await { | ||
| return Ok(()); | ||
| } | ||
| let mut secret_key = if let Ok(_) = tokio::fs::metadata(CONTRIB_SK_PATH).await { |
There was a problem hiding this comment.
clippy will probably tell you to use .is_ok() here
Comment on lines
+446
to
+448
| if lock | ||
| .compare_exchange(false, true, Ordering::SeqCst, Ordering::SeqCst) | ||
| .is_ok() => |
There was a problem hiding this comment.
writing to an atomic bool in an if guard is interesting, i would recommend pulling this out into the arm expression for clarity/ least surprise
Comment on lines
+577
to
+602
| tokio::select! { | ||
| Ok((stream, _)) = listener.accept() => { | ||
| let io = TokioIo::new(stream); | ||
| let status_clone = status_clone.clone(); | ||
| let tx_status_clone = tx_status_clone.clone(); | ||
| let lock_clone = lock.clone(); | ||
| let conn = hyper::server::conn::http1::Builder::new().serve_connection( | ||
| io, | ||
| service_fn(move |req| { | ||
| handle( | ||
| lock_clone.clone(), | ||
| tx_status_clone.clone(), | ||
| status_clone.clone(), | ||
| req, | ||
| ) | ||
| }), | ||
| ); | ||
| let fut = graceful.watch(conn); | ||
| tokio::task::spawn(async move { | ||
| let _ = fut.await; | ||
| }); | ||
| } | ||
| _ = token_clone.cancelled() => { | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
| match client | ||
| .current_contributor() | ||
| .await? | ||
| .ok_or(Error::ContributorNotFound) |
There was a problem hiding this comment.
why not match on the Option directly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.