Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for filtering on ID for hostpolicy objects. #564

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Add support for filtering on ID for hostpolicy objects. #564

merged 1 commit into from
Nov 21, 2024

Conversation

terjekv
Copy link
Collaborator

@terjekv terjekv commented Nov 21, 2024

Fixes the missing support for filtering on ID for Roles and Atoms in HostPolicy.

@terjekv terjekv self-assigned this Nov 21, 2024
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 98.656% (+0.002%) from 98.654%
when pulling 9a7af14 on fix_id_filtering_hostpolicy
into edcf871 on master.

pederhan
pederhan approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@pederhan pederhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I love Django filtering! 🤠

@terjekv terjekv merged commit 08e0e78 into master Nov 21, 2024
29 checks passed
@pederhan pederhan deleted the fix_id_filtering_hostpolicy branch November 21, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pederhan pederhan pederhan approved these changes

@oyvindhagberg oyvindhagberg Awaiting requested review from oyvindhagberg

Assignees

@terjekv terjekv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terjekv @coveralls @pederhan