Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update glpi_api.py to support update/add/delete sub_items #22

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

thel1988
Copy link
Contributor

This Change allows to call the api, and change sub_items without the need to keep track of sub item and their mother id.

glpi_api.py Outdated Show resolved Hide resolved
glpi_api.py Outdated Show resolved Hide resolved
glpi_api.py Outdated Show resolved Hide resolved
glpi_api.py Outdated Show resolved Hide resolved
@fmenabe
Copy link
Member

fmenabe commented Jan 23, 2024

Good thing I review the PR before merging it blindly, there are few things to correct in the update_sub_items method.

Copy link
Contributor Author

@thel1988 thel1988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are ofcause right, sorry for this :)
They have been corrected.

@thel1988 thel1988 requested a review from fmenabe January 23, 2024 13:49
@fmenabe fmenabe merged commit af845e3 into unistra:master Jan 23, 2024
@fmenabe
Copy link
Member

fmenabe commented Jan 23, 2024

Version 0.5.0 has been pushed on Pypi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants