Leave the scale factor into the unclaimed reward calculations #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkeating
reviewed
Mar 20, 2024
To avoid the accrual of precision loss as unclaimed rewards are calculated and checkpointed, we leave the scale factor in the unclaimed reward checkpoints. Our unclaimed reward method becomes a helper function only. We also add a test to ensure this precision loss does not accrue to a meaningful degree, even in extreme conditions.
alexkeating
reviewed
Mar 22, 2024
alexkeating
approved these changes
Mar 22, 2024
|
Coverage after merging scale-rewards into main will be
Coverage Report
|
|||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid the accrual of precision loss as unclaimed rewards are calculated and checkpointed, we leave the scale factor in the unclaimed reward checkpoints. Our unclaimed reward method becomes a helper function only. We also add a test to ensure this precision loss does not accrue to a meaningful degree, even in extreme conditions.
closes #70