Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HNiTS rename to match model naming convection #1000

Merged
merged 5 commits into from
Jun 11, 2022

Conversation

gdevos010
Copy link
Contributor

Fixes #947.

gdevos010 added 3 commits June 9, 2022 16:15

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Collaborator

@dennisbader dennisbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks a lot! 💯

Copy link
Contributor

@hrzn hrzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was actually intentional to not put the Model part (we also have other models without this - and when I added NHiTS I thought it is redundant, and somewhat came to regret that we have it on the other models). But if you think there are good reasons to have it, we could leave it I guess.
Was this motivated by any practical concern?

@gdevos010
Copy link
Contributor Author

It's for consistency. When I first started using the model, the name threw me off. They should all have it or none of them

@hrzn
Copy link
Contributor

hrzn commented Jun 11, 2022

It's for consistency. When I first started using the model, the name threw me off. They should all have it or none of them

OK, I guess I agree.

@hrzn hrzn merged commit 07c6a4d into unit8co:master Jun 11, 2022
@gdevos010 gdevos010 deleted the HNiTs-rename branch July 28, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Consistent model naming
3 participants