Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.10 & Remove prophet dependency #1023

Merged
merged 8 commits into from
Jun 21, 2022
Merged

Add Python 3.10 & Remove prophet dependency #1023

merged 8 commits into from
Jun 21, 2022

Conversation

hrzn
Copy link
Contributor

@hrzn hrzn commented Jun 21, 2022

No description provided.

@tomasvanpottelbergh
Copy link
Contributor

I think you missed some references in requirements/dev-all.txt and build.gradle

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2022

Codecov Report

Merging #1023 (274a66d) into master (b530dcd) will decrease coverage by 1.73%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master    #1023      +/-   ##
==========================================
- Coverage   93.04%   91.31%   -1.74%     
==========================================
  Files          77       77              
  Lines        7861     7861              
==========================================
- Hits         7314     7178     -136     
- Misses        547      683     +136     
Impacted Files Coverage Δ
darts/models/__init__.py 86.04% <25.00%> (+4.65%) ⬆️
darts/models/forecasting/prophet_model.py 4.31% <0.00%> (-89.93%) ⬇️
darts/logging.py 77.96% <0.00%> (-20.34%) ⬇️
darts/timeseries.py 91.99% <0.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b530dcd...274a66d. Read the comment docs.

Copy link
Contributor

@tomasvanpottelbergh tomasvanpottelbergh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still an uncaught exception in the import it seems, but rest looks good!

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@hrzn hrzn linked an issue Jun 21, 2022 that may be closed by this pull request
@hrzn hrzn merged commit 32d6b93 into master Jun 21, 2022
@hrzn hrzn deleted the feat/python310 branch June 21, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.10 support & drop prophet dependency
3 participants