Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: userguide/timeseries.md readability improvements #1039

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

ryanrussell
Copy link
Contributor

Signed-off-by: Ryan Russell git@ryanrussell.org

Small readability fixes in the TImeSeries user guide.

Signed-off-by: Ryan Russell <git@ryanrussell.org>
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2022

Codecov Report

Merging #1039 (51033e6) into master (945ded5) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1039      +/-   ##
==========================================
- Coverage   91.32%   91.30%   -0.02%     
==========================================
  Files          77       77              
  Lines        7870     7856      -14     
==========================================
- Hits         7187     7173      -14     
  Misses        683      683              
Impacted Files Coverage Δ
darts/models/__init__.py 86.04% <0.00%> (-0.32%) ⬇️
darts/timeseries.py 91.99% <0.00%> (-0.07%) ⬇️
...arts/models/forecasting/torch_forecasting_model.py 89.51% <0.00%> (-0.05%) ⬇️
darts/models/forecasting/block_rnn_model.py 98.14% <0.00%> (-0.04%) ⬇️
darts/models/forecasting/nhits.py 99.25% <0.00%> (-0.01%) ⬇️
darts/datasets/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 945ded5...51033e6. Read the comment docs.

Copy link
Contributor

@hrzn hrzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hrzn hrzn merged commit a632b37 into unit8co:master Jun 27, 2022
@ryanrussell
Copy link
Contributor Author

ryanrussell commented Jun 27, 2022

Thanks!

Hey @hrzn -- Great lib. I was going to go through and do more readability improvements...

I see Darts PR's ask for a bunch of reviewers...

What's the best way to go about more readability PR's without making it annoying?

Would it be better to make a single large PR with multiple commits in it so we don't have to play 5 person ping pong? :)

Best,
Ryan

@ryanrussell ryanrussell deleted the userguide-readability branch June 27, 2022 13:52
@hrzn
Copy link
Contributor

hrzn commented Jun 27, 2022

You're welcome @ryanrussell - yes, if you plan to make more improvements to the documentation (which is very welcome btw!), it'd be nice if you can bunch several of them in a single PR. Don't worry too much about pinging people in PRs, we like to do these reviews ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants