-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update coloring for graphs #1056
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this one. I think we could add it. Could you also maybe do the same for the plot()
function in TimeSeries
? Also we could maybe think of it as "default formatting" instead of limiting it to colors only, WDYT?
The tests are failing because of black - could you apply black and update?
Thanks for the feedback. All requested changes have been implemented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov Report
@@ Coverage Diff @@
## master #1056 +/- ##
==========================================
- Coverage 93.16% 93.16% -0.01%
==========================================
Files 78 78
Lines 7948 7941 -7
==========================================
- Hits 7405 7398 -7
Misses 543 543
Continue to review full report at Codecov.
|
Summary
Currently the charting in Darts messes up if you are using custom settings in matplotlib. I am creating a default colors argument so that users can choose whether they want Dart's default colors. If this is a desired feature I can add it to the rest of the charting functions in this file, and any other files you point out.