Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/filter static cov component #1128

Merged
merged 6 commits into from
Aug 7, 2022
Merged

Conversation

hrzn
Copy link
Contributor

@hrzn hrzn commented Aug 7, 2022

TimeSeries.univariate_component() was broken when the series contained static covariates, this fixes it (and simplifies the method).

Copy link
Collaborator

@dennisbader dennisbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! Added a minor comment

darts/timeseries.py Outdated Show resolved Hide resolved
hrzn and others added 2 commits August 7, 2022 21:02
@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2022

Codecov Report

Merging #1128 (06a822f) into master (caccce1) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1128      +/-   ##
==========================================
+ Coverage   93.65%   93.75%   +0.09%     
==========================================
  Files          79       80       +1     
  Lines        8137     8144       +7     
==========================================
+ Hits         7621     7635      +14     
+ Misses        516      509       -7     
Impacted Files Coverage Δ
darts/dataprocessing/dtw/dtw.py 94.20% <100.00%> (-0.13%) ⬇️
darts/models/components/transformer.py 100.00% <100.00%> (ø)
...arts/models/forecasting/torch_forecasting_model.py 89.54% <100.00%> (-0.05%) ⬇️
darts/models/forecasting/transformer_model.py 100.00% <100.00%> (ø)
darts/timeseries.py 92.23% <100.00%> (+0.01%) ⬆️
darts/models/forecasting/block_rnn_model.py 98.24% <0.00%> (-0.04%) ⬇️
darts/models/forecasting/nhits.py 98.55% <0.00%> (-0.02%) ⬇️
darts/datasets/__init__.py 100.00% <0.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hrzn hrzn merged commit 7ad25b4 into master Aug 7, 2022
@madtoinou madtoinou deleted the fix/filter-static-cov-component branch July 5, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants